Kristy Lee

Currently have the following code in writing: ``` private Function functionToCheckWhetherStorageEngineShouldBeKeptOrNot() { return storageEngineName -> { String storeName = Version.parseStoreFromKafkaTopicName(storageEngineName); if (VeniceSystemStoreType.META_STORE.isSystemStore(storeName)) { return true; } AbstractStorageEngine storageEngine = storageService.getStorageEngine(storageEngineName);...

Hi @kvargha, thanks for the pointers. I have revised the code to make the mapping work. ``` Set idealStatePartitionIds = new HashSet(); idealState.getPartitionSet().stream().forEach(partitionId -> { idealStatePartitionIds.add(Integer.parseInt(partitionId)); }); Set storageEnginePartitionIds =...

Here are the proposed constructor changes following the addition of the new `functionToCheckWhetherStorageEngineShouldBeKeptOrNot.` [Though, this function concerns checks with respect to partition]. In `createServices()`: ``` boolean whetherToRestoreDataPartitions = !isIsolatedIngestion() ||...

Here is the code to the function: ``` private Function functionToCheckWhetherStorageEngineShouldBeKeptOrNot() { return storageEngineName -> { String storeName = Version.parseStoreFromKafkaTopicName(storageEngineName); AbstractStorageEngine storageEngine = storageService.getStorageEngine(storageEngineName); PropertyKey.Builder propertyKeyBuilder = new PropertyKey.Builder(this.veniceConfigLoader.getVeniceClusterConfig().getClusterName()); IdealState...

From discussion, seems that the logic in DVC is as follows: In DVC, user actively specifies set of subscribed partitions. [Function: `subscribe()`] Another method for partition subscription is `bootstrap().` [Function:...

A few tests still have yet to pass with the changes that include the check for partition assignment. [e.g. this [test](https://github.com/linkedin/venice/actions/runs/11132688423/job/30943346267?pr=1196)] I have to check whether these are related to...

(Suggested addition to code, that seems directly useful but is no longer / not used actively: In the `HelixParticipationService` file, similar to the getInstance function, I also wrote a getHelixManager...

> (Suggested addition to code, that seems directly useful but is no longer / not used actively: > > In the `HelixParticipationService` file, similar to the getInstance function, I also...

I wrote the related unit test for this PR. GitHub tests pass for program, except for one Integration test unrelated to my change.

The check over which storage partitions to persist is moved to the shutdown phase of VeniceServer which was discussed. Shutdown phase contains call to `storageService.checkWhetherStoragePartitionsShouldBeKeptOrNot`. Services are also stopped when...