Krist Wongsuphasawat comments

Results 49 comments of


                                            Krist Wongsuphasawat

Fix pivot table setup verbose name

Please rebase

feat: add line-bar chart from nvd3

Thank you for your contribution. However, we are inclining on not adding new chart types to the current packages at the moment, especially when it introduces more complication on top...

feat: add line-bar chart from nvd3

I am working on a way for the plugin to be able to define control panel in itself. This way you can publish your own plugin as an `npm` package...

Table Rows do not render when using modern React stack

My team project uses this and the behavior we see now is `1.0.2` works for production but not development `1.1.0` works for development not production. Thank you for working on...

`scaleThreshold` has incorrectly strict `domain` typing

I'm not sure about this too. Had the same issue and had to manually specify generic type (what @hshoff did) to overcome. Note that it only occurs for non-continuous scales....

Adding scaleSequential to @visx/scale

`scaleSequentialXXX` are a bit different and may introduce some challenges: * How the scale is construct. The existing scales are using `input` array and `output` array. However, `scaleSequential` take `interpolator`...

Adding scaleSequential to @visx/scale

All in all, I would love to provide more compatibility with `d3-scale` but need to investigate a bit deeper into this.

Cannot set property 'order' of undefined

Having the same issue.

SplitLinePath takes a long time to render with certain curves

Thanks for reporting. Have you tried adjusting the `sampleRate`? Currently it is set at sampling every 1 pixel, but this might be faster if the `sampleRate` is > 1. ```tsx...

SplitLinePath takes a long time to render with certain curves

Another thing that might help is rounding the `x` and `y` position to fewer decimal points as svg can be much slower due to the length of path string. ```tsx...