Krist Wongsuphasawat comments

Results 49 comments of


                                            Krist Wongsuphasawat

Feature request: set signals from props

Thanks for suggesting. I'm trying to define the expected behavior before making any change. Would the signal get passed again if the spec change and the chart has to re-initialized?

[DRAFT] chore: set up auto for versioning/release management

Appreciate the effort in adding automation. Let me take some time to read through.

add a line to remove ace warning

Any chance of merging this?

Automatically scrolling cursor into view after selection change this will be disabled in the next version set editor.$blockScrolling = Infinity to disable this message

ui-ace.js

Automatically scrolling cursor into view after selection change this will be disabled in the next version set editor.$blockScrolling = Infinity to disable this message

I just create a pull request for this https://github.com/angular-ui/ui-ace/pull/111

Add region zooming when filtered by region.

Umm, thank you for your contribution krub. However, this approach is not robust a krub since all translation and scale are hard coded, which is subjected to `size`, `padding` and...

Cherry pick lodash to decrease bundle size?

Can also use `import { random } from 'lodash'` and use `babel-plugin-lodash`

Cherry pick lodash to decrease bundle size?

Use `flow` instead of `_.chain` krub and other functions from `lodash/fp` instead of `lodash`.

Allow Loading Data via Symlink

Still an issue?

fix(#125): emit remove filter

Have you verified that this works as intended? Could you add some explanation of the behaviors before/after?