Kristaps Kaupe

When payjoin fails, should ask for user confirmation for non-payjoin send

2

When non-coinjoin sends are made with `sendpayment.py` or JoinMarketQt GUI, before sending out transaction, user is asked for Yes / No confirmation. But when payjoin attempt is made and it...

Should be added. We should be sure we don't break compatibility for output of both `wallet-tool.py showutxos` and `/utxos` wallet RPC API.

Cache transaction data in wallet to speed up `history` method of `wallet-tool.py`

10

Currently it is really slow. Likely some optimizations are possible even without adding new data to wallet file, but ultimate solution IMHO is caching. For wallet with around 1000 transactions...

Change avoidance

1

Wasabi Wallet has a feature that at transaction preview before sending transaction will suggest changing send amount little bit if that allows to avoid having change. It would be useful...

Store structured history data somewhere

2

See https://github.com/dennisreimann/joinmarket-log-parser. It's a tool that analyzes JoinMarket log files and extracts structured data from them. It would make sense to store that data in structured manner by JoinMarket itself....

Create all wallets with fidelity bond support by default?

2

It there a reason to ask user a question to enable or not enable fidelity bond support when creating new wallets instead of always enabling it?

When one or more onion dnode(s) are unavailable when sending privmsg, user gets error msg, but don't have feedback which one it was

1

When there is try to send privmsg to an unavailable message channel, user gets errors like this: ``` [ERROR] Tried to communicate on this message channel but failed: onion-network [ERROR]...

It's bad to have different functions for the same thing, `coins_to_satoshi()` were already used in some tests.

In #1436 exponentional delay was added to reconnect attempts to dnodes with idea that if individual ones are not working at the moment to not do too many useless reconnect...

RBF code should be refactored and support added to RPC API and Qt GUI

2

Currently a lot of code is in `scripts/bumpfee.py`, should be moved to `jmclient`, so that both RPC API and Qt GUI could use it.