Kristaps Kaupe
Kristaps Kaupe
Currently tests on Python 3.12 are failing. https://github.com/roshii/joinmarket-clientserver/actions/runs/6681650313/job/18155992988 https://github.com/roshii/joinmarket-clientserver/actions/runs/6681650313/job/18155993117
Currently it just keeps running after reciving tx to specified address. But that means sender just sent non-payjoin tx and address reuse is bad in any case. ``` $ ./scripts/receive-payjoin.py...
Displays unhandled error and hangs. ``` $ ./scripts/sendpayment.py testnet-test-124.jmdat "bitcoin:tb1qjhzn0n46u0szatr5833rk80mhf9caqn6knmwxq?amount=0.00200000&pj=http://w6k7nba4rx4jieyumt7z3zrmk5sq5kymhly74oxe63loazqctt7j3vid.onion" User data location: /home/user/.joinmarket/ 2024-02-05 16:24:36,119 [DEBUG] rpc: getblockchaininfo [] 2024-02-05 16:24:36,121 [DEBUG] rpc: listwallets [] 2024-02-05 16:24:36,121 [DEBUG] rpc:...
`_estimate_fee_basic` is supposed to return `None` if fee rate can't be estimated and then `estimate_fee_per_kb` handles that with hardcoded fallback fee. But `JsonRpcError` wasn't handled and it could fail when...
There is a new BIP for this, from Craig Raw, Sparrow Wallet dev - https://github.com/bitcoin/bips/blob/master/bip-0329.mediawiki. There is also old alternaive standard for this by Trezor - https://github.com/satoshilabs/slips/blob/master/slip-0015.md. Looks to me...
Ended up disabling native jm onion in joinmarket.cfg and using IRC only. Then payment succeeded fast. Shouldn't be like that, if one messaging channel is working and others aren't, should...
Does it makes sense? Probably could be useful, user could check it from time to time, remember or write down this info and then would know gap limit he would...
Resolves #1533. My first attempt at adding new RPC-API endpoint, there could be mistakes. Didn't add tests in `jmclient/test/test_wallet_rpc.py` as message signing is currently supported for mainnet only, not regtest...
There is no point in running lint scripts on all OS / Python combinations. Saves some CI minutes.
Happened randomly while testing #1642. Doesn't seem related to these changes in any way and also wasn't able to reproduce with second test run. In any case, something to investigate...