Kris Baumgarter

Results 47 comments of Kris Baumgarter

I'd also like to discuss making `renderer.physicallyCorrectLights = true` by default. See: https://github.com/pmndrs/react-three-fiber/issues/2127

Maybe having the props split up like this for advanced users: ```jsx ``` Then if I am doing a postprocessing workflow, assuming 'lit' is the default, I can just do:...

> I'm certainly not opposed to exposing more granular options if they're clearly and precisely named. I would caution that these "short guides" can get quickly get more complicated as...

I was reimplementing the postprocessing library myself to see what might be the problem and I was able to reproduce this issue by _**not**_ setting the render frameBufferType to HalfFloatType....

So just to follow up, you can fix this issue yourself by setting the `frameBufferType` prop on `EffectComposer` to `HalfFloatType` which you import from three.

Yeah I feel the same way as Cody. I want to see `physicallyCorrectLights` become default (along with decay of 2) and will support that change but I feel like it...

The same is true for R3F users too. All our demos and tutorials are made with `physicallyCorrectLights=false` and making the change would mean at least updating all of those and...

> I don't think we can change defaults for lighting OOTB, problems are detailed in the linked issue. That might be a consideration for #2299 but the issue of `decay`...

I'm in favor, the typing is hugely improved and so is compatibility with context. But it isn't a trivial update. Is it something you would be interested in spearheading? I...

That would be great. If you start a branch, I can do review and assist.