Krishna Mahato

Results 20 comments of Krishna Mahato

@GMishx PTAL at the recent changes. All the requested changes are resolved.

> Except changes noted above, tests are working as expected. @GMishx resolved all the requested changes. Recent changes are pushed to the PR.

> @krishna9304 Please rebase the branch to resolve merge conflict. Yes, Done!

@GMishx applied the PATCH and implemented the API using existing methods. PTAL at the recent changes.

> Please download: [rest-api.patch.txt](https://github.com/fossology/fossology/files/9280816/rest-api.patch.txt) > > @krishna9304 please rename the file by removing `.txt` and apply the patch to the PR to fix the test cases. Done!

> @krishna9304 apologies, I pressed the wrong button an pushed the merge commit to the branch. Can you please rebase it with current master and remove the merge commit? Sure,...

> ![image](https://user-images.githubusercontent.com/18077542/184346066-5c5b4a1b-b98b-4c8e-a321-65c88e68a6b1.png) > > Please check the image for required changes in response of `GET repo/api/v1/uploads/{id}/perm-groups` endpoint. > > The `PUT repo/api/v1/uploads/{id}/permissions` endpoint is working as expected. @GMishx - Okay,...

> > @GMishx > > ``` > > * Okay, I'll remove the `perm_upload_pk` parameter. > > > > * Sending an indexed object for the groups with permissions response...

> @krishna9304 some changes are required in open api docs > > ```diff > diff --git a/src/www/ui/api/documentation/openapi.yaml b/src/www/ui/api/documentation/openapi.yaml > index 82e1a7e5d..7d3598c43 100644 > --- a/src/www/ui/api/documentation/openapi.yaml > +++ b/src/www/ui/api/documentation/openapi.yaml > @@...