Kris Bitney

Results 39 comments of Kris Bitney

Okay. Thanks for the response. I love as-pect, by the way. You do great work. > On Feb 24, 2022, at 6:03 PM, jtenner ***@***.***> wrote: > > > Hey....

Resolved by https://github.com/polywrap/toolchain/pull/1231

What do you think of making the default URI called be the first one in the list of interface implementations in the client config?

It seems expensive to construct a plugin instance to get the config. What are the pros and cons of changing the `PluginPackage` type to include a pointer to the config?...

All of that makes sense. Thanks!

> Could you get tests to pass @krisbitney? We should make sure the AssemblyScript compiler doesn't complain about these keywords-as-type-properties by adding a few more tests for commonly used keywords:...

After looking into it further, I don't think it's possible to instantiate a class from an object literal when you declare a constructor. I thought it would be possible because...

> How about, > > ```ts > return { > "const": "foo", > } > ``` > > Does this compile with asc? that's a really good question. I'll find...

> How about, > > ```ts > return { > "const": "foo", > } > ``` > > Does this compile with asc? Yes, this works. This PR will allow...

> Don't we still need to handleKeywords for module methods. > > Ex: > > ```graphql > type Query { > type(token: String!): TokenType! > } > ``` > >...