Alon Zakai

We may want to work around this like other false positives we've seen, e.g. https://github.com/WebAssembly/binaryen/pull/6912/files A PR would be welcome. You can also disable warnings when compiling, as an immediate...

> A stupid nit - if it was based on wasi libc, shouldn't there be copyright attribution somewhere? (Or is that not necessary?) We should keep the copyright and license...

@sbc100 See https://v8.dev/blog/emscripten-standalone-wasm#necessary-api-differences regarding the overhead and other issues that prevented us from moving emscripten to use 100% WASI APIs. But perhaps WASI has improved since then?

The only update I'm aware of is that we now have better JS fallback options. You can build to JS instead of wasm using `-s WASM=0` (in either fastcomp or...

I agree. Earlier discussion here: https://github.com/WebAssembly/design/issues/445 Still not too late to fix this! :)

Yeah, basically the wasm isn't fully generated yet... disabling assertions fixes asserts that expect those contents, but I wonder if we might hit other issues later. If so, for Asyncify...

sgtm (why am I assigned?)

I believe name section ID 3 is for labels (names of blocks and loops inside functions). Looks like we don't support that atm, so we will drop those names after...

No other issues in that wasm file, and looks like it optimizes well, ``` Metrics total [exports] : 7 [funcs] : 10 -3 [globals] : 0 -1 [imports] : 0...

`wasm-opt` does not emit the names section by default (to avoid the risk of shipping wasted bytes in production). Use `-g` to get it: https://github.com/WebAssembly/binaryen/blob/1d2e23d5e55788091a51420ba3a9889d4efe7509/test/lit/help/wasm-opt.test#L642-L644