Results 1275 comments of Alon Zakai

Very interesting @giniedp ! If you think it's ready, a PR to add a link to that in the docs would be great.

This extra traversal of all the code worries me. Can IRBuilder not collect those pointers as it creates things?

Can you explain the difference between the two cases? I don't follow that. Isn't this extra pass over the module always done when there are names, so the overhead is...

Yeah, maybe we can avoid it somehow, but I think atm we do figure out names late for some things. So IIUC, is 6% the relevant overhead, then? Overall my...

6% seems high to me. Maybe it's because I've been working on a series of such optimizations recently (moderate speedups, some of which involving avoiding an extra pass on the...

I see, so to validate before lowering instead of after... But now `string.const` may validate with `--enable-strings` but fail if the user adds `--enable-string-builtins` - that is, doesn't this break...

I see. And either of the two features would enable `string.const`? That seems possible, though two features for one IR construct is also odd. I suppose strings is just in...

Not sure what you mean by "reality" here, sorry? I would lean to strings being the only thing that validates string consts. Then conceptually lifting is "string builtins => stringref"...

Btw, related to string opts, https://github.com/WebAssembly/binaryen/pull/7631 adds links from wasm-opt's help to the wiki, and I updated the wiki to mention string opts, https://github.com/WebAssembly/binaryen/wiki/GC-Optimization-Guidebook#strings If that current process is burdensome...

> In browsers, string builtins is a different feature than stringref, so modeling them as separate features in Binaryen is more precise. But you are also saying > either of...