Kristoffer Johansson comments

Results 12 comments of


                                            Kristoffer Johansson

grpc-proxy: subsequent client watchers hangs after auth token expires

I can see now that the description might be a big vague. I will try and clarify the issue with more details. The problem can be reproduced like this: -...

grpc-proxy: subsequent client watchers hangs after auth token expires

Hi, just checking if anyone has had time to take a look at this? @ivanvc

grpc-proxy: subsequent client watchers hangs after auth token expires

@nwnt Ive added a PR with possible solution in https://github.com/etcd-io/etcd/pull/19033 which addresses this issue, would be great to get your feedback on the approach.

grpcproxy: use metadata instead of context withvalue in with client auth token

Added test case which reproduces the issue, with included change it passes but without fails

grpcproxy: use metadata instead of context withvalue in with client auth token

Have anyone had the chance to have a look at this? pinging from reveiwers in owners file, @fuweid @ivanvc

grpcproxy: use metadata instead of context withvalue in with client auth token

Hello @ivanvc ok, got it will open an issue so possible solutions can be discussed, thanks.

grpcproxy: use metadata instead of context withvalue in with client auth token

/retest

grpcproxy: use metadata instead of context withvalue in with client auth token

@ivanvc sure no problem, just rebased and pushed

grpcproxy: use metadata instead of context withvalue in with client auth token

Hi @ivanvc just checking if anyone have had time to look at this PR?

grpcproxy: use metadata instead of context withvalue in with client auth token

> Pls squash the commit, thx sure, just squashed and pushed