php-docraptor icon indicating copy to clipboard operation
php-docraptor copied to clipboard

Make it composer installable

Open markushausammann opened this issue 9 years ago • 13 comments

Even the most simple dependency deserves to be composer installable!

markushausammann avatar Apr 01 '15 15:04 markushausammann

Feel free to make it composer installable. I've never used composer and don't much work in PHP anymore.

krewenki avatar Apr 01 '15 15:04 krewenki

@krewenki Would you like to transfer ownership of this to the DocRaptor owners for maintenance? Otherwise we will probably fork it and deal with this stuff there.

janxious avatar Apr 01 '15 15:04 janxious

I was just planning on "forking", resp. actually just starting a new project. What ETA do you have @janxious ?

markushausammann avatar Apr 01 '15 15:04 markushausammann

@markushausammann It would probably take me multiple days to get it done since I haven't used composer either. If you're willing to make a PR against a forked project, I am happy to review and merge such a thing at your earliest convenience.

janxious avatar Apr 01 '15 15:04 janxious

That's a good solution, I will make a PR against your fork, just tell me when it's ready. Using packagist, everything can be setup in a way that every time you tag a release, packagist automatically publishes the new package version. You might want to open a packagist.org account or I'll register it through mine. Packagist is the default package repository for composer, which is what gem is to ruby, just better ;).

markushausammann avatar Apr 01 '15 15:04 markushausammann

Actually you should open your own packagist.org account because you need an API key to set the hook up on github.

markushausammann avatar Apr 01 '15 15:04 markushausammann

Repo is gonna be here: https://github.com/expectedbehavior/php-docraptor

janxious avatar Apr 01 '15 15:04 janxious

Would you like to make changes before I make the composer PR?

markushausammann avatar Apr 01 '15 15:04 markushausammann

@markushausammann Yeah, I am pulling in some PRs from this repo and making a few changes. Almost there.

janxious avatar Apr 01 '15 17:04 janxious

@markushausammann I have made all the changes to the EB version of this thing, so PR away!

janxious avatar Apr 01 '15 18:04 janxious

@janxious can we chat somewhere, I think I'm ready with the PR and I've got a few more PRs planned, if you're interested.

markushausammann avatar Apr 01 '15 22:04 markushausammann

And could you open the issue tracker?

markushausammann avatar Apr 01 '15 22:04 markushausammann

Issue tracker is opened. Let's continue this chat over there.

janxious avatar Apr 01 '15 22:04 janxious