Jannic Beck

Results 13 comments of Jannic Beck

I am not sure how to handle the test coverage decrease. Proper testing could involve running multiple _tox_ environments and merging the coverage reports.

Alternatively, marshmallow could be pinned to

@circulon, you can check the `.circleci/config.yml` to see how to run the code coverage tests locally. But my fear is that this project is dead (and it is not about...

@circulon I don't know. Personally, I am now sticking to plain Marshmallow.

> This goes in the direction of adding a second NodeVisitor class, but avoids traversing the AST twice. Or do you think a second NodeVisitor class (with all of these...

I am not sure if passing `_define` as `report` into `Reachaiblity` is the cleanest solution, but I did not want to create a new datastructure that passes the information back...

I had a look at it again, and I think it is cleaner to also move the `_handle_conditional_node` into the `reachablitly.py` (such that the module handles the entire `self.unreachable_code` `LoggingList`...

I updated - `check_unreachable` for checking multiple unreachable code segments (alternative would be to add another method for that or assert that there is only a single unreachable code segment...

Just randomly reading this. > but we need the yield statement there to make the method into a generator! May I ask what the `yield` makes for a difference? So...

I agree that that type checker and code readability can probably easily be managed (type annotation, custom decorator, custom exception). For runtime checks I thought about the following: ``` class...