kr
Given the way binarydist is currently implemented, a fork sounds reasonable. (I think it would be preferable for binarydist to write the diff directly to the given Writer (if it's...
This still seems like a gotcha for other projects using ct, so I'd like to keep it open.
I think the ideal behavior here from ct would be: - if the test process finishes the test successfully, it kills all descendants with SIGTERM - it waits for them...
My rough plan for how to do this happens mostly in `start` at the end of the child branch. Here's what it does currently: ```c ... // setup test process...
I think it's fine to reserve and release a bunch of jobs just so you can display them. If you have more than one worker, they're not guaranteed to run...
I suggest not supporting compound data in a log message. It is much easier conceptually (and as a practical matter when writing tools to process logs) if each log message...
> I would be inclined to indeed set the flag by default, but it requires some exploration to make sure it doesn't break existing code bases. > > > >...
> That is, removing line 50, and relying on the caller to close the primary/master terminal (pty) after they have done `cmd.Wait()`, I'm not sure if there is a bug...
As a side note, the variable names `pty` and `tty` might not have been the best choice; I do not know if those are standard names to label the two...
FWIW I agree there should be a high bar to justify incompatible changes to the interface. It's not immediately clear to me why that would be necessary to add Windows...