Alex Korzhikov
Alex Korzhikov
@beeing That's a nice proposal. Do you think it will be a whole package size? Because yes, of course it matters, but mostly for browser.
Probably it's because the image is `distroless` ```bash ➜ clair-scanner git:(master) ✗ ./clair-scanner --log="./test.json" --exit-when-no-features=true --reportAll=true --clair=http://0.0.0.0:6060 --ip host.docker.internal local-opa 2020/08/27 15:32:17 [INFO] ▶ Start clair-scanner 2020/08/27 15:32:18 [INFO] ▶...
Takeaways from NodeConf - Use v8 flags to test performance - Use hasOwnProperty instead of a.b
Same for validators, f.e. ```javascript tpl('if (')(schema.allOf.map(reference => tpl.resolve(reference)) .join('(%s) || '), tpl.data)('(%s))', tpl.data)(tpl.error('allOf')); ``` could be rewritten with a es6 template (that is for investigation)
- add destructuring for template, it will make code cleaner
Moved to the next release, as I expect there will be some bugfixes related to utils as well, and also some work is already done - https://github.com/korzio/djv/commit/6c994916aa619ac44505a57a3fafb679d2760b40
@Anthropic Yes, it would be, I agree. It is better to have validators do work in a similar style. I would plan this as an enhancement for the next minor...
https://gitter.im/korzio/djv?at=59f1ba7b210ac26920327dfb
@aboyton Yes, I understand. The current approach is just the easiest one. This task is about standard formatted messages and it is planned for the next sprint.
@aboyton If you are interested, @Anthropic has been working on a nice validators adapters package and he's already done good work [regarding the messages standardisation](https://github.com/jsonschema/assimilate/blob/master/src/use/validator/djv.ts#L8) for `djv` library. 👍