Dan Kortschak

Results 342 comments of Dan Kortschak

[This](https://github.com/golang/go/wiki/CodeReviewComments) will answer some of your questions. Data Type is two words, so it can be made `DataType`, though do think `Type` is better. Dataspace is a single compound word,...

@eaburns, I was thinking similar things - this is probably related to @vdobler's CSS proposal.

Sorry for the delay in responding. Can you provide a minimal complete reproducer?

Please paste the code you are using here.

The issue is that d is passed in as a non-addressable type. The full panic for reference is ``` panic: reflect.Value.UnsafeAddr of unaddressable value goroutine 1 [running]: reflect.Value.UnsafeAddr(...) /home/user/go/src/reflect/value.go:1972 gonum.org/v1/hdf5.(*Dataset).WriteSubset(0xc000098380,...

There is something that goes [most of the way to this in plotutil](https://github.com/gonum/plot/blob/master/plotutil/plotutil.go). This uses globals and probably shouldn't to allow concurrent use, but if that were fixed would that...

I don't think this is the responsibility of palette. Note that palette.Diverging is an interface, so the user can define any type of colour mapping symmetry. The actual mapping of...

What would that look like and how would the information propagate to the plotter (at the moment the critical value is not used by any plotter)?

This also allows the possibility of exporting some of these helpers.