Derek Cormier

Results 36 comments of Derek Cormier

> @kormide does this need a rebase? @devversion Yep, rebased.

This would be a very useful feature to have when building with Bazel, which relies on deterministic artifacts for good remote cache performance.

Note that I was able to work around this by fixing the date in the file entry when appending to a zip: ```javascript zip.append(content, {name: "foo.txt", date: new Date(0)}); ```

I have an old PR that does this, but I don't think we reached an agreement: https://github.com/aspect-build/rules_js/pull/837.

Rebased to fix merge conflicts.

@devversion I pushed a commit to address your feedback points.

Yeah I was thinking something along those lines as well.

Only downside is that there isn't an easy way to do this check with `cp`. We have to add some more complicated logic to search for potential conflicts first (I...

> @kormide WDYT about naming the new rule `wrap_binary(chdir = "")` so that we'd add the other features to it, rather than make more wrapper if you need to do...

The more I think about it, the more I can see how an "everything" macro could get out of hand. I think I'm going to change my opinion here and...