korlov42

> The sad thing is Calcite users would get similar issues: they would get wrong results/wrong plans, and nobody would know the reason. Before this patch, they could get a...

@vlsi, I've added a `@Deprecated` on the Project's constructor. This highlighted a bunch of missed places (primarily, adapters). So all of them are fixed now, I suppose. With this deprecation...

Hi, @zabetak! Seems like 10 days have passed. Now it's my turn to be unavailable for next 10 days, but I really hope you'll find time to review this.

Hi, @zabetak! Sorry for pushing, but is there any chance you'll find the time to help me get this PR done?

To be honest, I didn't get this patch. Could you please sed some light on the root cause of the problem and the idea of proposed solution?

@suibianwanwank thanks! The only thing I'm a little bit concerned about is that `LogicalProject` now exposes `variablesSet` in certain cases. But as far as I see this is valid approach...

> BTW, I think we could move `changeCorrelateReferences` into `RelOptUtil`. Also, we could consider renaming it, for example, changing `change` to `mapping`. thanks for suggestion, done. See changes in [this...

> From my understanding, variablesSet'is indispensable, in nested subQueries, it clearly defines the source of variables. I absolutely agree with you. I only wanted to highlight that this particular change...