Karolin Varner

Results 221 comments of Karolin Varner

There is more dead code in that file too…

@cvengler Thanks for your PR! I just simply removed the entire integration test in #376

Thank you for submitting this PR; it looks very nice. What worries me a bit is the lack of integration tests checking whether the CLI keeps functioning, so its hard...

Good to hear @nextgens; no worries, I know how busy a maintainer's life is. Happy to hear! I might be able to implement that. Is there anyone we should loop...

@MAVRICK-1 This looks like a decent contribution. Would you be open to setting up a video call so we can discuss the changes and you can give me a demo?...

> The generate config script requires the following change: > > ```diff > diff --git a/misc/generate_configs.py b/misc/generate_configs.py > index 5a1997a..620dce4 100644 > --- a/misc/generate_configs.py > +++ b/misc/generate_configs.py > @@ -20,7...

This is done. Please give it a review if you care to @blipp @aparcar @pqcfox

Thanks for updating the liboqs version here. This is a breaking change; the main requirement for updating to liboqs is that we introduce a configuration flags to fall back to...