Karolin Varner

https://github.com/stv0g/go-rosenpass/blob/d7e38ecaf9e7803f2824a03ac24ac34944a53af6/handshake_initiator.go#L101 https://github.com/stv0g/go-rosenpass/blob/d7e38ecaf9e7803f2824a03ac24ac34944a53af6/server.go#L143 **Severity: 3 (Dangerous)** – No IO should be performed in response to maliciously crafted messages as performing IO opens up pandoras box in regards to DOS attacks (think...

**Severerity: N/A** – Have you made sure to exclude the possibility of errors inside processing triggered by network messages that could crash the application?

**Severerity: N/A** – What is the situation with regards to buffer overflows, use-after-free errors in go?

**Severerity: N/A** – What is the situation with regards to printf-like-injection attacks, shell injection attacks, log-injection attacks in go? I have seen some format strings.

**Severerity: N/A** – Is it possible to write allocation-free code in go? The implementation must not have network-dependent memory usage and it should not allocate in response to network messages.

**Severerity: N/A** – What is the situation with regards to switch-case-fallthrough and none of the branches of a switch statement being covered in go?

https://github.com/stv0g/go-rosenpass/blob/d7e38ecaf9e7803f2824a03ac24ac34944a53af6/messages.go#L88 **Severity: B** – Can we please avoid using sentinel values like that and use something like the Rust Result type instead? Can we use unsigned values? Where are unsigned...

https://github.com/stv0g/go-rosenpass/blob/d7e38ecaf9e7803f2824a03ac24ac34944a53af6/messages.go#L184-201 **Severity: B** – Manual offset arithmetic like that is treacherous. There is a danger of subtle errors. In the Rust implementation we put a lot of work into writing...

https://github.com/stv0g/go-rosenpass/blob/d7e38ecaf9e7803f2824a03ac24ac34944a53af6/server.go#L200-L203 **Severity: 2 (Severe)** – At this point in the handshake the initiator is not authenticated. This version of the code allows anyone to create a fake package and overwrite...

https://github.com/stv0g/go-rosenpass/blob/d7e38ecaf9e7803f2824a03ac24ac34944a53af6/server.go#L251 **Severity: N/A** – How do you make sure all these locks never cause a dead-lock situation?