koponen-styra comments

Results 5 comments of


                                            koponen-styra

Consider dropping use of github.com/pkg/errors package

golang 1.13 is only 8 months old, though. Not sure if we should give it a bit more time before we require 1.13+ for OPA.

Consider dropping use of github.com/pkg/errors package

Of all the vendored dependencies, it looks like at the moment github.com/yashtewari/glob-intersection is the only one with a dependency to pkg/errors. I prepared a PR to fix that: https://github.com/yashtewari/glob-intersection/pull/2 After...

Consider dropping use of github.com/pkg/errors package

github.com/yashtewari/glob-intersection has removed its dependency to pkg/errors.

Add built-in function support to verify PGP signatures

Having golang.org/x/crypto as a dependency sounds useful, indeed. I'm my limited experience with the library its exported APIs have been stable.

Hidden, unnecessary assumptions about the AST object iteration order

The AST sets would benefit from similar treatment. With both objects and sets, removing the iteration order assumption opens the path towards removing the `keys` field within their implementation which...