Sebastian Herrlinger comments

Results 232 comments of


                                            Sebastian Herrlinger

Importing OpenTUI stops Effect from properly running teardown hooks

Yes, that would be it basically.

test(tui): Set up TUI tests

I am not using a debugger at the moment, so I can't really help with the breakpoint problem, although I suspect the solid plugin compilation messing up the line numbers,...

test(tui): Set up TUI tests

Cool, I'll review in a bit. Is that segfault reproducible somehow in a test?

refactor(renderer): Separate render loop from single frame rendering

Hey, thanks for contributing! I see your concerns. I need to test this. For me the loop() method is basically the render method, just running one cycle. Extracting that would...

fix: Exception when selecting text on destroyed component

The `TextBufferView` is a low level API that wraps the FFI bindings and I made the guard throw so it can be caught, instead of causing a segfault when accessing...

OpenTUI: ctrl-z background controls are broken

Opencode needs to re-map the undo for the Textarea to not collide with other mappings.

OpenTUI: ctrl-z background controls are broken

`ctrl+z` should not be mapped by default anymore

docs: add badges + showcasing

The default-parsers is auto generated. Need to adjust the generator, but formatting is unnecessary as it would be overwritten again.

testRender: user input leaks through

The testing setup currently isn't actually mocking process.stdin, the input mocks for key/mouse are writing to the actual process.stdin

Support Node/Deno (NAPI instead of bun:ffi)

I am open to it. FFI was just really convenient and is faster than NAPI, but yes I gave it some thought already. Might happen at some point, just not...