Sebastian Herrlinger comments

Results 232 comments of


                                            Sebastian Herrlinger

[FEATURE]: Support cursor position and text selection using mouse in chat input - Like Warp

Will come

feat: add index control in the select component

Cool

feat: add index control in the select component

/oc can you generate a test suite for the select component, covering the basics like we do for the Slider or Input for example?

feat: add index control in the select component

/oc there is a test failing in the pipeline for this PR, check it. can you make sure we clamp the index from the given config to length-1 of the...

feat: add index control in the select component

/oc one more test failing. Check it. moveUp is emitting the event even though the actual selection did not change. moveDown does the same basically. Just leave it like that...

Allow for <select> to have no currently selected option, or allow to hide that the option is selected when the <select> is not focused

Yeah that makes sense.

test: Add comprehensive React test suite with SolidJS feature parity

@zenyr yes, this one was testing the CJK issue workaround, which is hopefully fixed. @msmps maintains react and he has plans for it.

fix: Fix worker.ts path for production and dev

Thanks for checking, I saw this one yesterday and it should fix the issue https://github.com/sst/opencode/pull/3778

Importing OpenTUI stops Effect from properly running teardown hooks

So my perspective was things run on/in opentui, not opentui on/in another framework/lib. That's obviously one sided. What I could see working here is defining a shutdown behaviour that can...

Importing OpenTUI stops Effect from properly running teardown hooks

Yes to returning the renderer and yes to "opentui should not control the lifecycle", that is app responsibility. I think the Behaviours would get way too complex and complicated. If...