Konrad Mikucki

Results 14 comments of Konrad Mikucki

reverting to `:last-child` will cause this warning: https://stackoverflow.com/questions/57239807/the-pseudo-class-first-child-is-potentially-unsafe-when-doing-server-side-ren

This issue conflicts with https://github.com/mattermost/mattermost-server/issues/15975, which I'm currently working on. Changes in theme settings component will be significant. I'll write it in TS.

I have some considerations according this issue and would know your opinion. ## Existing users who never changed theme Figma file states: > Default setting for ‘Sync with OS appearance’:...

I'm rethinking how to store theme preferences and I'm seeing some defects in my proposal. I'll describe my thoughts soon.

When writing first proposal, I wasn't aware of team-specific themes. If we continue to use `theme` category we will not be able to detect if this `theme` was saved before...

@hmhealey Agree that json in db may cause problems. How should we store information if sync is enabled? I was thinking about two options: 1. add preference category `disable_theme_sync` -...

Or maybe third option, without adding additional preference category: `theme` exists => not sync, use this theme `theme` and `theme_dark` exists => sync, use these themes `theme` not exists and...

@hmhealey So first option wins (`disable_theme_sync` preference)?

Just for information: I haven't had time to deal with this issue for the past two weeks. But now I'm working on it again.