Mitsunori Komatsu

Results 111 comments of Mitsunori Komatsu

Great to hear that! I think we need to delay to create a `MessageBufferInput` instance until https://github.com/msgpack/msgpack-java/blob/edd094282368d26fff7808ca792faa0ce488be61/msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackParser.java#L169. It means the private constructor needs to receive both of `byte[]` and `InputStream`...

@koo-taejin Thanks. Looked over the branch (not PR, right?) Unfortunately, the change is too much more than I expected. Especially `core` component shouldn't be changed as much as possible since...

@koo-taejin I tried to reproduce the memory consumption difference with your change based on https://github.com/msgpack/msgpack-java/blob/develop/msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/benchmark/MessagePackDataformatPojoBenchmarkTest.java, but I didn't see any significant difference (I used `jcmd PID GC.class_histogram`.) Could you give...

@koo-taejin Thanks for the information. But even based on the code you shared above, I don't think we can add tests code that is needed to see if the fix...

@frosiere I got your point. But, whether to move the log to DEBUG level or remove it depends on the use case. Also introducing a configuration to change the log...

How to handle `BufferFullException` is up to the application. For instance, the application can avoid calling `Fluency.emit()` for a while after catching `BufferFullException` thrown from `Fluency.emit()`. This option makes sense...

@benjamin-dreux I tried your code in the `example` project and it worked well. See https://github.com/komamitsu/spring-data-sqlite/blob/example-converter/example/src/main/java/org/komamitsu.springdata.sqlite.example/Main.java#L34-L39 and related code for details.

``` public interface ContactRepository extends ListCrudRepository { ``` According to this code, you didn't use `SqliteRepository` ? It would be great if you isolate the cause by checking if your...

I meant your code didn't seem to use Spring Data JDBC integration for SQLite. `SqliteRepository` needs to be extended by Repository interfaces to use the feature.

As I mentioned above, I don't think you encountered those issues with using Spring Data JDBC for SQLite, since your code didn't use `SqliteRepository`.