Kir Kolyshkin

libct/cg/sd: optimize and test findDeviceGroup

6

~~_This includes/depends on #3356, draft until merged._~~ 1. Using strings.TrimPrefix instead of fmt.Sscanf. 2. Add a test case and a benchmark. The benchmark shows some improvement, compared to the old...

shell files: enable `set -u -e -o pipefail`.

1

We should make our shell code more strict, in particular: - [x] enable `set -u` so that using an unset variable (which is most probably due to bad logic in...

Add "Update with rebase" button

6

We were seeing 2 or 3 cases when merging two pull requests results in a non-compilable code in main branch. This is because PRs are usually not rebased. I have...

``` === RUN TestWriteCgroupFileHandlesInterrupt file_test.go:38: Failed to write 1147642 on attempt 99066: failed to write "1147642": write /sys/fs/cgroup/memory/test-eint-174937648/memory.limit_in_bytes: no such device --- FAIL: TestWriteCgroupFileHandlesInterrupt (0.96s) ``` From https://cirrus-ci.com/task/5995808356040704, while testing...

[RFC] enable discussions

8

**Problem**: there are quite a few new issues filed that are not bug reports, but rather some questions or comments about runc. **Current solution**: mark those with `question` label (thanks...

Seen on https://cirrus-ci.com/task/5467129087524864?logs=integration_systemd#L99. ``` not ok 76 kill detached busybox # (in test file tests/integration/kill.bats, line 27) # `[ "$status" -eq 0 ]' failed # runc spec (status=0): # #...

[proposal/rfc] Use github-native review process, say goodbye to pullapprove

11

(similar to https://github.com/opencontainers/runc/issues/2388) Pullappove was probably added when github did not have its own mechanism to do LGTMs. For quite some time, such a mechanism exists: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/approving-a-pull-request-with-required-reviews There is also...

Sometimes a standard package from a particular Go release introduces a regression which can be fixed by using a modified copy of it. So, it would be nice to have...

This is a carry of #688, using a slightly different fix. In addition, it adds a test case, and fixes the error texts. Closes: https://github.com/opencontainers/runtime-tools/pull/688

RFE: drop libseccomp < 2.5.0 support

2

Currently, this library has a number of quirks and workarounds to work with older libseccomp. Some of these were removed by https://github.com/seccomp/libseccomp-golang/commit/449387b6d401d2ca8e231ae21e10ff5ef75ac86d. Requiring libseccomp >= 2.5.0 should simplify some code....