Kir Kolyshkin
Kir Kolyshkin
> or adding a linter exception for now That is what I did for now. Might try to properly fix this in go-errorlint later...
https://pkg.go.dev/golang.org/x/sys/unix#section-documentation says: > These calls return err == nil to indicate success; otherwise err represents an operating system error describing the failure and holds a value of type syscall.Errno. Summoning...
With go 1.18, you can use ```console [kir@kir-rhat ~]$ go version -m `which ineffassign` /home/kir/go/bin/ineffassign: go1.18.1 path github.com/gordonklaus/ineffassign mod github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8 h1:PVRE9d4AQKmbelZ7emNig1+NT27DUmKZn5qXxfio54U= dep golang.org/x/mod v0.4.2 h1:Gz96sIWK3OalVv/I/qNygP42zyoKp3xptRVCWRFEBvo= dep golang.org/x/sys v0.0.0-20210510120138-977fb7262007 h1:gG67DSER+11cZvqIMb8S8bt0vZtiN6xWYARwirrOSfE=...
Let me rephrase the original issue; maybe it will make it more clear. I have the following json input: ```json { "foo": true } ``` and I want to use...
> I think it should be a goal to drop more of the args here rather than passing them into Annotations() I agree. Anything more than 3-5 string parameters already...
verify / lint failure is being fixed by https://github.com/cri-o/cri-o/pull/5918
> It doesn't seem to be in 1.22 or 1.23 yet 1.22: https://github.com/cri-o/cri-o/pull/5920 1.23: https://github.com/cri-o/cri-o/pull/5921
Do we need a test case?