kokkos-tools

kokkos-tools copied to clipboard

Remove KOKKOSTOOLS_LIBRARY_MODE

1

`KOKKOSTOOLS_LIBRARY_MODE` isn't a CMake variable (and not documented) and there doesn't seem much of an advantage over using the implicit `BUILD_SHARED_LIBS` option. Note that `kp_add_library` expects all extra arguments to...

masterleinad

Don't link against kokkostools in tests unconditionally

1

Tests would normally just use environment variables to load the respective tool. In any case, we shouldn't link to `kokkostools` unconditionally. Tests that set the respective hooks explicitly would not...

masterleinad

Sampler's begin for callee's null check before fence (less overhead in corner case)

1

This PR is simple fix involving a slight reduction in Kokkos Tools runtime overhead for one of the kokkosp_begin_parallel_xyz callbacks (done correctly for the other two); it does not raise...

vlkale

Perfetto results dependent on compile time setup

2

Hi there, I'm trying to integrate these tools into a HPC code https://github.com/PHAREHUB/PHARE/ I've noticed that if compile with the following ``` CMAKE_CXX_FLAGS="-DNDEBUG -g0 -O3 -march=native -mtune=native" CMAKE_BUILD_TYPE="Release" ``` I...

PhilipDeegan

User Documentation of Kokkos Tools TPL Connectors

9

This issue aims to lay groundwork on the centralized documentation of Kokkos Tools vendor aTPL connectors, i.e., advanced TPL connectors. Documentation of aTPLs is different from the documentation for basic...

vlkale

Compilation with Kokkos develop broken after Kokkos PR 7394

2

Compilation of `kokkos-tools` with `kokkos` develop is broken after - https://github.com/kokkos/kokkos/pull/7394 The reason seems to be that the `kokkos` PR moved the function `int_for_synchronization_reason` from `Kokkos_Profiling.hpp` to `Kokkos_Profiling_Interface.hpp`. However, this...

maartenarnst

Kernel logger upgrades for better output and better code comparisons

6

This PR does two things: 1) Upgrades the output on the Kernel logger to look more like the Tpetra DeepCopyTools --- rather than output space ID's we demanagle that and...

csiefer2

Variorium Connector: kernel granularity and JSON

17

Updates to the current connector with updates such as json updates, energy estimation, device information. It has also been altered to get power information at the kernel level.

twilk10

Because the call to `project` can be expected to already set `CMAKE_CXX_COMPILER` - https://github.com/kokkos/kokkos-tools/blob/a9453b21e09c7555096f3a96bb3fa8b34afe19f8/CMakeLists.txt#L3 the option `KokkosTools_REUSE_KOKKOS_COMPILER` can no longer change `CMAKE_CXX_COMPILER` - https://github.com/kokkos/kokkos-tools/blob/a9453b21e09c7555096f3a96bb3fa8b34afe19f8/CMakeLists.txt#L65-L68 so the option `KokkosTools_REUSE_KOKKOS_COMPILER` can be...

maartenarnst

cannot convert `json_t*` to `char**` in variorum connector, gcc 12.2.1

1

https://github.com/kokkos/kokkos-tools/blob/a9453b21e09c7555096f3a96bb3fa8b34afe19f8/profiling/variorum-connector/variorum-connector.cpp#L96 gcc 12.2.1 on rzadams

cwpearson