kokkos-tools icon indicating copy to clipboard operation
kokkos-tools copied to clipboard

Don't link against kokkostools in tests unconditionally

Open masterleinad opened this issue 9 months ago • 1 comments

Tests would normally just use environment variables to load the respective tool. In any case, we shouldn't link to kokkostools unconditionally. Tests that set the respective hooks explicitly would not use the environment variable KOKKOS_TOOLS_LIBS and only link against kokkostools that can either happen explicitly or via another argument to kp_add_executable_and_test.

masterleinad avatar Apr 29 '24 15:04 masterleinad

Thanks @masterleinad

Imposing kokkostools (monolithic) library requirement only for those Kokkos Tools tests needing it will make it easier for users to run the Kokkos Tools tests on their own platforms. I think none of the tests in develop need more than the individual (not monolithic) library for KOKKOS_TOOLS_LIBS.

vlkale avatar Apr 29 '24 19:04 vlkale