Ondrej Kokes
Ondrej Kokes
@nxadm thanks for the prompt reply, I have three bits of news: 1. I pushed a new branch to house it all, I can submit a PR from that if...
So I looked into it a little more and got stuck. Even with my newline implementation, I get issues with properly buffering partial lines and it's getting a bit yucky....
Upon further reflections (and failing to implement a working solution on top of the library), I decided to rework it in a different branch, this time giving the user an...
@nxadm having run this in our pre-production setting for the past 10 days or so (works well), I decided to submit a PR. I only used the latter approach, I...
@nxadm Note that the buffer is NOT filled in the default case (CompleteLines: false). https://github.com/kokes/tail/blob/224135092b774b93c11480ca8f503f171ea90d85/tail.go#L247-L252 The buffer is only used when CompleteLines is set to true - I accepted your...
@nxadm not sure if that's coming - fsnotify [hasn't had a code/dependency change commited since the last release](https://github.com/fsnotify/fsnotify/compare/v1.5.1..HEAD), so I wouldn't expect it anytime soon.
You're understanding it exactly right. We don't have a particularly strong preference for this, we just don't see enough value in keeping this data in a separate file. Plus we...
Cool cool cool. I'm in no rush, we're still evaluating what our options are and we can replicate our desired workflow even with lock files, so it's not a blocker....
@michaelperel Cool, this works as expected. I only ran into one weird edge case. Not sure if that's a good practice, but some of my Docker FROM clauses look like...
@michaelperel makes sense. I guess a log message about a given image being ignored due to the lack of tags would be useful. This way it just silently ignores it,...