small_gicp icon indicating copy to clipboard operation
small_gicp copied to clipboard

Performance issues with smallgicp, while the old fast-gicp version does very well with the same data. PCD is too small warning.

Open VTrencsenyi opened this issue 1 year ago • 4 comments

The fast-gicp version of GICP works pretty well with my python pipeline and data. However, with small-gicp I keep getting the warning "target/source pcd is too small" and the resulting accuracy is very poor. Do you have any intuition where the difference may be coming from? Note, this is the case regardless of downsampling.

VTrencsenyi avatar Sep 02 '24 11:09 VTrencsenyi

The warning on the point cloud size is shown when the number of points is less or equals to 10, that indicates something strange is happening on your input point clouds. Can you provide minimum example code and data to reproduce the problem? https://github.com/koide3/small_gicp/blob/e669301de3d90c490ff169a9abd1be8c31816b3f/include/small_gicp/registration/registration.hpp#L34

koide3 avatar Sep 03 '24 06:09 koide3

Hi, Koide3. When I tried to run the code in the 01_basic_registration.cpp from the example, this problem occurred. However, I didn't modify any code. Before the program runs to the align function, the sizes of the target and source point clouds are normal. But during the execution of the align function, the following warnings are generated: warning: Empty point cloud warning: Empty point cloud warning: target point cloud is too small. |target|=0 warning: source point cloud is too small. |source|=0 Setting the downsampling_resolution in the setting to 0.0 also generates the same warnings.

junwei1999 avatar Feb 08 '25 08:02 junwei1999

@junwei1999 Can you print out the number of points just before running example1? https://github.com/koide3/small_gicp/blob/2c5e9e6092f06bd8b4a0c618c9714e39e4b315dc/src/example/01_basic_registration.cpp#L66

koide3 avatar Feb 10 '25 01:02 koide3

Koide3, thank you for your reply.  The following figure shows the size of the target point cloud and the source point cloud before entering the align function.

However, when entering the align template function, the size of both target and source become 0.

It seems that only the references are passed and nothing is done, yet the data is lost.

------------------ 原始邮件 ------------------ 发件人: "koide3/small_gicp" @.>; 发送时间: 2025年2月10日(星期一) 上午9:42 @.>; @.@.>; 主题: Re: [koide3/small_gicp] Performance issues with smallgicp, while the old fast-gicp version does very well with the same data. PCD is too small warning. (Issue #89)

@junwei1999 Can you print out the number of points just before running example1? https://github.com/koide3/small_gicp/blob/2c5e9e6092f06bd8b4a0c618c9714e39e4b315dc/src/example/01_basic_registration.cpp#L66

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

junwei1999 avatar Feb 10 '25 01:02 junwei1999