iridescence icon indicating copy to clipboard operation
iridescence copied to clipboard

glm_FOUND should be GLM_FOUND

Open themightyoarfish opened this issue 1 year ago • 2 comments

Similar to my other issues, this applies to macos. I have glm from homebrew (1.0.1) and after

find_package(glm)

The variable glm_FOUND is empty, but GLM_FOUND is TRUE. Thus the logic of downloading glm inside the build tree triggers unintentionally. The vendored FindGLM.cmake uses uppercase, the homebrew module uses lowercase.

themightyoarfish avatar Nov 29 '24 12:11 themightyoarfish

I also think that iridescence-config.cmake is missing a call to

find_dependency(glm)

because client projects otherwise error.

themightyoarfish avatar Nov 29 '24 12:11 themightyoarfish

Thanks for reporting the issue. I'll fix the first one by checking both glm_FOUND and GLM_FOUND. I'll update CMakeLists to resolve both soon.

koide3 avatar Dec 07 '24 00:12 koide3