glim icon indicating copy to clipboard operation
glim copied to clipboard

Ready pointcloud with intensity

Open VanavaraDigital opened this issue 1 year ago • 5 comments

Hello, thank you for your great work. I have one trouble: Exported Pointcloud has no intensity value of points. I learned source code and see, that frames points have intensity values, but next step, when you produce submaps from frames, submaps points have no intensity value. Does it possible to add intensity values to points in exported pointcloud ?

Thanks

VanavaraDigital avatar Jul 25 '24 14:07 VanavaraDigital

The intensity information is lost in the frame merge in sub mapping. If you want intensity data, you need to modify the following part to retain the original intensity information.

https://github.com/koide3/glim/blob/3d65b3b72a730b6b41fc667ed639bae5c29ca78a/src/glim/mapping/sub_mapping.cpp#L461

koide3 avatar Jul 26 '24 01:07 koide3

The intensity information is lost in the frame merge in sub mapping. If you want intensity data, you need to modify the following part to retain the original intensity information.

https://github.com/koide3/glim/blob/3d65b3b72a730b6b41fc667ed639bae5c29ca78a/src/glim/mapping/sub_mapping.cpp#L461

Hello,I need to modify the function gtsam_points::merge_frames_auto to add intensity information,but I can't locate where the function was implemented, maybe I should rewrite it by myself? thank you for your reply

ahengn avatar Aug 07 '24 07:08 ahengn

merge_frames_* are in gtsam_points. I'm thinking of implementing a merge function with intensity support, but it has a low priority for now.

koide3 avatar Aug 08 '24 12:08 koide3

merge_frames_* are in gtsam_points. I'm thinking of implementing a merge function with intensity support, but it has a low priority for now.

Thanks,I found the declaration of merge_frames_* in the file point_cloud_cpu.hpp,but it seems there is no corresponding function implemention in the file point_cloud_cpu.cpp.?

ahengn avatar Aug 09 '24 01:08 ahengn

Thank you for your guidance on handling intensities with gtsam_points. Following your advice, I have implemented the following enhancements:

  • Intensity Handling in gtsam_points: Modified gtsam_points to support intensity data.
  • Intensity Export in GLIM's Offline Viewer: Updated GLIM's Offline Viewer to include intensity data when exporting maps, provided the submap contains intensity information.

These changes enable GLIM to process and export intensity data effectively. I've created branches in my forks for both repositories:

  • GLIM: https://github.com/h-wata/glim/tree/feature/export_ply_with_intensities
  • gtsam_points: https://github.com/h-wata/gtsam_points/tree/feature/add_intensities

Feel free to explore these branches if you're interested.

h-wata avatar Nov 21 '24 09:11 h-wata