Cristiano Köhler
Cristiano Köhler
I can confirm that the behavior is improved. When installing from this branch, in a configuration that is known for build failure, the `optional` feature works. Apparently, the build fails,...
However, when using the `--install-option='--nofim', build is not attempted. ``` WARNING: Disabling all use of wheels due to the use of --build-option / --global-option / --install-option. Collecting git+https://github.com/INM-6/elephant.git@fix/do_not_compile_extension Cloning https://github.com/INM-6/elephant.git...
It works for the develop option (`pip install -e . --install-option='--nofim'`) from the repo cloned locally. Trying to use the `optional` by just passing `pip install -e .` fails: ```...
So, unless the `develop` install failure when not passing the `--nofim` flag is expected, this is the only current problem. Apart from that, as raised in the comments below, the...
Regarding this topic, the description of the outputs also needs better clarification in the docs. For instance, the output dictionary is complex, with elements that will be present depending on...
A comment regarding the changes, as several are due to the change in the string representation of NumPy types (obtained by the built-in `repr`). An alternative to avoid having the...
The last changes fix the doctests to work with NumPy 2.0 while keeping the old-style NumPy formatting in the docstrings (NumPy 1.25). The solution was to create a `conftest.py` dynamically...
Implemented additional test cases to validate the computation of `_PMatNeighbors` when using distinct number of threads, and a new specific test class for the high-level API in `ASSET.joint_probability_matrix`.
The implementation looks good. I made small suggestions to improve the warnings and structure of the unit test.