Dominik Köppl

Thanks for the pull request. It would be wonderful if you could have a look at `compressors/lcpcomp/compress/PLCPPeaksStrategy.hpp` and tell me if there is a difference in the output. While your...

Thanks for this comparison. Indeed, the line at https://github.com/tudocomp/tudocomp/blob/b596cf1f09d358d2e1004db00326d4a99e0a4581/include/tudocomp/compressors/lcpcomp/compress/PLCPPeaksStrategy.hpp#L50 for PLCPPeaksStrategy.hpp should be fixed by removing some unnecessary conditions like `plcp[i] > plcp[i-1])`. But I think your code is cleaner....

I would have rewritten it as `if(i == last_replacement_pos && plcp[i] >= threshold) {` or even better: with a jump in the for loop by `i+= factor_length` such that the...

Thanks. Now the source code looks pretty clean. I think it is only left to rename the source file to something meaningful like lexparse, and maybe add a comment to...

I think that the version using the Phi array uses less memory during the factorization. I think it would be interesting to evaluate this. This can be done by running...

> Do you have it declared twice in the registry? I am using `/etc/registries/lcpcomp.py` of the master branch, but could not find a duplicate. > Binary is likely never the...