vincent d warmerdam

Results 391 comments of vincent d warmerdam

There is another one of these datasets that seems to have similar results. ![CleanShot 2024-05-25 at 15 10 43](https://github.com/skrub-data/skrub/assets/1019791/29b94f63-d275-4926-b658-828a89848da7) I want to add one caveat here because these datasets are...

The splines aren't perfect for sure, but they've thusfar always seemed simple enough and also pragmatic in the sense that it's a simple thing to reason about. I do recall...

That's a fair concern, but I am not sure what the user might expect besides "sensible defaults". The most general seasonal pattern feels like it might be to do 'something...

> I also wonder if the current interface of the DatetimeEncoder is suitable for adding those features or if parameters should be in terms of "which cycles to represent" rather...

> Does that more or less address the problem you are facing? I think it does, just one thing. How would the `DateTimeSplines` featurizer know which columns to select/ignore. Does...

> However, if the important part is not really the name "date" but rather applying the spline transformer to datetime columns only Do we want to assume that the user...

To my knowledge polars now does support WASM. There are still some hiccups with pyarrow, but polars seems to run fine in many of my WASM marimo notebooks.

@FBruzzesi so this came up during the code spring. It indeed seems that our `OutlierRemover` doesn't have a `transform` method. And I also just noticed that we also only allow...

That does feel better, yeah. Let's do that and update the docs accordingly.

I think we can drop the `TransformerMixin` here if we want it to be more like a resampler. Then again, part of me would also be "ok" with dropping this...