vincent d warmerdam

Results 322 comments of vincent d warmerdam

I didn't know grep could be used to search through multiple files. But if so, I suppose so.

It's mainly that if my project has 1000 pages with dead links, it's great to know that there's a deadlink ... but in order to fix it I'd need to...

> In the output of deadlink check, yes? That'd probably make some sense. Correct! I suppose it wouldn't hurt to have a flag for it, but I'll gladly leave it...

i've merged v2 of counterfactuals yesterday by the way. these now use the aggregated node tables.

so the counterfactual api, turns out, is fundamentally broken. feel free to ignore anything from that api.

https://github.com/koaning/brent/pull/31

Something in me worries about floating point arithmetic, but yeah it seems sensible. If the output ever gets normalised with all zeros then some crazy voodoo might happen on the...

this graph prolly will result in a good laugh. ![image](https://user-images.githubusercontent.com/1019791/54077792-ca316e00-42bd-11e9-910e-2f286ca1b59d.png)

I gave it a quick review while in the train. Will try to give it a better review tomorrow back home. For the future though, it would be better if...

So first of all; I do like the direction of the PR. I was planning on doing images too, so it's nice to see that other folks had the same...