vincent d warmerdam

Results 376 comments of vincent d warmerdam

A few points on my end. 1. Will you be able to pass in multiple aspects, say `PeriodicityEncoder(aspects=['day', 'hour'])`? You could also use a `FeatureUnion` but is there a use-case...

Feel free to make a PR to fix it. Just referring to the lower corner seems fine.

I'm very happy to hear that you enjoy the scikit-lego project as well as calmcode, but I would like the emphasize that scikit-lego isn't *my* package. It's a collaborative effort...

You're free to pick it up if you'd like. We're still keeping an eye on the repository, but ever since the pandemic hit we've been less active in picking up...

I like the idea and it's certainly valid statement, but we'd like this library to remain compatible with scikit-learn primarily. I can imagine that it gets complicated for users too...

We can combine with this: https://github.com/koaning/scikit-lego/issues/328

@MBrouns I've made an implementation and it is making me reconsider. ```python import pandas as pd class RefitPolicy: _sort_func_name = "final_score_sort" def __init__(self): self.filter_funcs = [] self.assignments = [] self.sorting_func...

Yes. It'd be cool to have it combined in some way here: https://scikit-lego.readthedocs.io/en/latest/mixture-methods.html.

I've used something similar in gitlab before but haven't used it over on the github side yet. It sounds like a useful feature but there is a catch. Pricing is...

Are you sure? The [docs suggest](https://docs.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows#example-using-the-cache-action) that we might need to manually keep track of versions because actions requires a key in the form of a filehash. In our case...