Raphael 'kena' Poss

Decode context.Canceled, context.DeadlineExceeded etc as a reference to the stdlib instance

1

Currently, instances of the stdlib errors trasnferred over the network are decoded into an object of the same type/value, but not the same instance. So reference comparisons with `==` with...

Currently the UnimplementedError constructors consider the messages as always unsafe. These should be given the same treatement as Newf/Wrapf.

Suggested by @andreimatei in https://github.com/cockroachdb/cockroach/pull/43032#pullrequestreview-334181315: `AssertionFailedf` is usually called in functions with a `context.Context` available. It would be beneficial to capture the context tags to provide more details during troubleshooting.

Feedback: `server.identity_map.configuration` is not sufficiently documented

1

Raphael ‘kena’ Poss (knz) commented: ## What is the reason for your feedback? The cluster setting `server.identity_map.configuration` can be used in a diversity of deployment types. In particular, it is...

Every time a bubble calls `key.Matches` the key is rendered as a string and then the string is compared. This is inefficient, and also the heap allocation (1 for each...

Notable Event Types Doc Update - An include directive is not expanded properly

7

Raphael ‘kena’ Poss (knz) commented: Re: [Notable Event Types](https://cockroachlabs.com/docs/v21.1/eventlog.html) See:  The include should be expanded into a callout instead. cc @taroface Jira Issue: DOC-1584

speaker(4): drop NEEDGIANT

1

NB: I have also uploaded this in Phabricator as https://reviews.freebsd.org/D54168 **Summary:** the calls to `disable_intr()` / `enable_intr()` in `spkr.c` were leftover from previous refactorings and unnecessary for correctness, so this...