Tomasz Knopik comments

Results 6 comments of


                                            Tomasz Knopik

Phase transition metrics should include a corresponding node name

I'm happy to implement this improvement once we agree on the approach, thanks!

Phase transition metrics should include a corresponding node name

@davidvossel do you know who I could discuss this improvement with?

Phase transition metrics should include a corresponding node name

@xpivarc yes, it will increase the metric cardinality (for phase transitions that actually have corresponding node name). I believe that this is the cost of more granular monitoring. I was...

Phase transition metrics should include a corresponding node name

@xpivarc do you have any thoughts?

Phase transition metrics should include a corresponding node name

@xpivarc @sradco any thoughts on this?

Add go-tfdata integration (tests)

``` git config --global url."ssh://[email protected]:12051/".insteadOf "https://github.com/NVIDIA/go-tfdata" ``` might be even better, and then no `replace` in `go.mod`. I'll try to change it.