Konstantin Maksimov
Konstantin Maksimov
@PiotrSikora @mathetake can you please review? This is a follow-up change for https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/198. Thanks.
@PiotrSikora @mathetake would you please review this? Initial big-endian changes have already been merged in https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/198, but now I'd like to fix null-vm use case. Thanks.
@mathetake thanks for the review. I've opened an issue and added the error details https://github.com/proxy-wasm/proxy-wasm-cpp-host/issues/294. Can you please take a look?
@PiotrSikora thanks for the review, I've made the proposed changes, can you please take a look?
@PiotrSikora I've made the requested changes: - Moved the calls to isWasmByteOrder() into htowasm/wasmtoh macros, now it should be removed by preprocessor for non-s390x. - Added surrounding brackets to htowasm/wasmtoh...
@mpwarres thanks for the review, please see my comments.
@PiotrSikora I've made the changes, can you please take a look?