knguyen1

Results 28 comments of knguyen1

fix(directory): Fix overflow char and add unit tests

Please review @nathom

EMR process hang

What are these tasks? They take a long time. And that is a large file being written to disk. ``` 24/08/07 13:49:41 INFO TaskSetManager: Finished task 993.0 in stage 3052.0...

feat(aws): add s3 support to input, storage, output, cache, etc.

@microsoft-github-policy-service agree

feat(aws): add s3 support to input, storage, output, cache, etc.

> Can you add the option to enter the endpoint URL to the boto3 client as well so that storage to other platforms such as minIO is also possible through...

feat(aws): add s3 support to input, storage, output, cache, etc.

Please review @natoverse

feat(aws): add s3 support to input, storage, output, cache, etc.

@natoverse @AlonsoGuevara review please?

feat(aws): add s3 support to input, storage, output, cache, etc.

Unless you review this PR soon, I'm going to close without merging. I am now getting conflicts too numerous and too complex to resolve cleanly. @natoverse @AlonsoGuevara

feat(aws): add s3 support to input, storage, output, cache, etc.

Resolved conflicts and rebased: https://github.com/microsoft/graphrag/pull/1830/commits/40b0affffbe3d4f5049f95868470fac3fd8f07bf Moved s3 configs to `StorageConfig` class: https://github.com/microsoft/graphrag/pull/1830/commits/e8936365976171aa165e2425d1ead526f0176608 Update documentation: https://github.com/microsoft/graphrag/pull/1830/commits/980371e286890667fd9832eebc12e1037637cd41 @natoverse @AlonsoGuevara

feat(aws): add s3 support to input, storage, output, cache, etc.

Closing due to inactivity.

🐛 Still can't ignore nested biome.json configuration

I have a similar problem (same?) to this. Here's my project structure: ## Project Structure ``` my_project/ ├── .pre-commit-config.yaml ← Pre-commit configuration (root) ├── biome.json ← Biome config (root) -...