eli knaap
eli knaap
cool. I think 1 is covered by the existing test using I? just need to add a generic callable test for 2?
i think there's something weird with my github at the moment. All my review comments say 'pending' too. Let me see
just checked this guy. try again?
this all makes sense to me. Thanks @ljwolf !
@ljwolf thanks for the lowess version, looks great. Should we also implement/document that this version works a little differently [than geoda](https://geodacenter.github.io/workbook/5a_global_auto/lab5a.html#creating-a-spatial-correlogram), which, apart from using lowesss also seems to work...
teamwork ftw
yes, yes only question is whether we want to keep both `plot_legendgram` and `plot_histogram` since we don't really need the latter anymore
dunno either, but also not sure how would we issue a deprecation warning in meta? (other than include in the meta release notes)
for some reason the precommit hook removes the `import lonboard.geopandas` line from the example notebook