integrate `legendgram` into `mapclassify`?

[jGaboardi]

xref https://github.com/pysal/legendgram/issues/21

[martinfleis]

This was briefly discussed in https://github.com/pysal/mapclassify/pull/216 and I guess that it could simply end up as an extension of that function, no?

[jGaboardi]

So considering #234 & #250:

1. Can this issue be closed?
2. Should we begin ramping down legendgram for archival?

[knaaptime]

yes, yes

only question is whether we want to keep both plot_legendgram and plot_histogram since we don't really need the latter anymore

[jGaboardi]

yes, yes

only question is whether we want to keep both plot_legendgram and plot_histogram since we don't really need the latter anymore

If we don't need, let's go ahead and dump it?

@sjsrey @martinfleis – thoughts here?

[sjsrey]

The ci is failing, I believe this has to do with something our dependencies changing so that the image checks in legendgram are failing in most cases.

[jGaboardi]

The RMS tolerance is very small, so I'd bet it's simply differences in matplotlib installs/versions. I have experienced this previously when installing matplotlib via PyPI vs. Conda-forge

[sjsrey]

yes, yes only question is whether we want to keep both plot_legendgram and plot_histogram since we don't really need the latter anymore

If we don't need, let's go ahead and dump it?

@sjsrey @martinfleis – thoughts here?

I would keep plot_histogram around.

[jGaboardi]

OK, so I'll go ahead and close this out and we can reopen if needed.