Girish Kumar

Results 9 comments of Girish Kumar

> Could you try GO111MODULE=on go install github.com/prometheus/prometheus/cmd/promtool@main ? @roidelapluie ``` go install github.com/prometheus/prometheus/cmd/promtool@main: github.com/prometheus/[email protected] The go.mod file for the module providing named packages contains one or more replace directives....

> This is a warning, I expect. @roidelapluie but not able to install `promtool` with above command. Return code by the `go install` is `1`.

> Was the batch produced at the offset you're consuming from very large? Kafka does not return individual records, only batches. If I understand correctly, if the producer created a...

@twmb We were able to reproduce the issue, and it seems to be caused by the larger batch size. Thanks for the help—learned something new today! :)

@agentCalculator It seems the ddotel package is creating a new error using `trace.WithError()` inside `span.End()`, which uses the status description provided by the `span.SetStatus` with golang [std errors package](https://pkg.go.dev/errors#New) when...

Hi, I’ve opened a PR to address this issue: https://github.com/DataDog/dd-trace-go/pull/3702. The goal of this change is to prevent `(*span).End()` from overriding user-defined error fields like error.message, error.type, and error.stack, which...

Adding a bit more context on **why the PR gates on the presence of the `error` attribute instead of checking `error.message` / `error.type` / `error.stack` individually**: - **Those three fields...

@mtoffl01 We’re seeing this behavior only when a span is explicitly marked as failed using `SetStatus`, which is commonly done by most tracing interceptors. For example: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/instrumentation/google.golang.org/grpc/otelgrpc/v0.62.0/instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L339 In cases where...

#### Just to add more context Most OpenTelemetry interceptors, including the gRPC ones, set the span status to Error when the operation fails — for example, when the gRPC response...