Mikhail Korobov comments

Results 524 comments of


                                            Mikhail Korobov

Scrapy should handle "invalid" relative URLs better

I'm fine with closing this issue if the bug in Python 2-only. We're not yet ready for Python 3 (e.g. telnet is not ported), but I think Scrapy is close...

Scrapy should handle "invalid" relative URLs better

FTR: this issue is fixed in Python 3.5.2; it is still present in Python 3.4.6 and 2.7.13

Meta var for skip cache read for request

See also: https://github.com/scrapy/scrapy/pull/821

Meta var for skip cache read for request

@tonal could you please explain what is the use case for this, i.e. why do you want to write to the cache, but not to read from it?

Checking if defer gets an error callback while in start_request and killing process

Rasing `sys.exit(1)` makes sense; I think the approach is correct. Thanks for the PR!

[MRG+1] Let allowed domains be updated in offsite middleware

Sorry, could you please clarify - what is the use case? Why would anyone want to update allowed_domains?

Switch auto field stats to an item pipeline

The code looks good 👍 But I haven't checked how it works, and if it solves the issue :)

Command line option post

I think that the code duplication should be made smaller before merging.

[MRG+1] Allow updating dictionary-like settings with magic prefix

The PR looks good to me, +1 to merge.

[MRG+1] Allow updating dictionary-like settings with magic prefix

I liked `update:` because we can't use it in settings, so there is a clear distinction between a command and an option name.