Konrad Michalik comments

Results 6 comments of


                                            Konrad Michalik

[android] layout shift bug on new architecture

Hi @Prajwaltechversant We're still trying different approaches to the case. I pushed some code to the PR - can You check if [2d9dff2](https://github.com/software-mansion/react-native-screens/pull/3295/commits/2d9dff25973e5c3dfe1d41c3b3e38b4f2db09d4c) is better now? I still can see...

[android] layout shift bug on new architecture

Please look at the attached PR. This is as far as we are able to fix the issue. About the padding, we advice against using padding in screen style prop...

Warning: Can't perform a React state update on a component that hasn't mounted yet. This indicates that you have a side-effect in your render function that asynchronously later calls tries to update the component. Move this work to useEffect instead.

Hi I've tried the code in https://github.com/grantackerman/rns-react-state-error-repro and the bug is indeed still present. However I'm not getting the same error on our FabricExample setup with react-navigation. I started simplifying...

Android: Up/back on search should cancel search, not navigate

The issue seems to have been solved by now I don't see the problem when running the provided example My simple test https://github.com/user-attachments/assets/01f3f1b9-a2cb-43c3-b503-af5814498dbd https://github.com/user-attachments/assets/a349ef73-ce5b-45b8-ac1c-4b028b1961a1 If I'm missing something, please let...

Android: Up/back on search should cancel search, not navigate

Okay, I tested on an example native app and I see the difference in behavior in "

Draft: fix(iOS): Reorder back button setup logic so iOS renders it correctly when displayMode=minimal

It looked fine-ish until I tried the other way around, from first to third, to first, to second. Now second is always minimal. I'd say it's not an improvement then....