Kurt Barry
Kurt Barry
> cc: @kmbarry1 you were asking for this a while back I believe? Hey! Yeah, this gets partially at what I was thinking of. The even more powerful thing would...
> Yeah definitely agree re: the cheat code, but that's a bit of a bigger job for another day. Sounds good--and I might still take a crack at it if...
I might use `"Fl*pper/auction-not-active"` as opposed to `"Fl*pper/guy-not-set"` as that's more likely to be meaningful to someone debugging a failed transaction.
Thinking about this more, we should consider just wrapping the `tick` logic in `if (bids[id].guy != 0) { ... }` for backwards compatibility. But maybe that doesn't matter.
I will give it a try today!
Also, just to give "official" comment on this: looks good, but there are two things I want to check prior to merging: 1) gas for `x != 0 && n...
Am getting through the backlog of changes that are definitely going in before analyzing this.
Confirmed the same as Julien--code matches the `DssProxyActionsEndCropper` contract from commit [c755fd6](https://github.com/makerdao/dss-crop-join/pull/34/commits/c755fd62f876f0b25a93028392dc850c0dc49f6e) modulo minor interface name changes from flattening. Constructor args match appropriate contracts. LGTM for chainlog inclusion.
I would agree that it certainly doesn't make sense to charge a fee post-`thaw`, although it doesn't hurt the system--it just has no benefit as the surplus can't be distributed...
1. Agree the issue goes away if `Line` is set quite high, although then you lose any protection it might otherwise provide. 2. Ah yes, I like the async profit...