Greg Netsas comments

Results 1139 comments of


                                            Greg Netsas

[DX] Is the use of `get_t()` in the output of `theme_form_element_label()` really necessary?

@kiamlaluno `!required` is basically an asterisk inside an `` HTML tag, with a specific/fixed title **_as an attribute_**, and the value of that attribute is always "This field is required.",...

[DX] Is the use of `get_t()` in the output of `theme_form_element_label()` really necessary?

> ... but translators should be able to place the asterisk before or after the title, depending on what is done in their language. If that is the case, then:...

[DX] Is the use of `get_t()` in the output of `theme_form_element_label()` really necessary?

> Translators are already asked to translate *[!site-name] !subject*. Following the same reasoning, `t()` should not be used with `'[!site-name] !subject'` because the site name and the subject are just...

[DX] Is the use of `get_t()` in the output of `theme_form_element_label()` really necessary?

> If by *context* you mean the `'context'` array key used in the array passed as third parameter to `t()`, that is possible, ... Yes, that is what I mean...

[DX] Is the use of `get_t()` in the output of `theme_form_element_label()` really necessary?

Well, contexts are meant to be used in order to help translators when things are ambiguous or similar words may have different meanings. In the case of `!title !required`, as...

[DX] Replace use of `strtr()` in `theme_form_element()` with standardized `backdrop_html_class()` instead.

2-line PR here: https://github.com/backdrop/backdrop/pull/4800

[DX] Replace use of `strtr()` in `theme_form_element()` with standardized `backdrop_html_class()` instead.

...as an alternative, I'm happy to add a couple of `@todo`s there instead, as reminder to clean that up in Backdrop 2.0.

Issue #1529: Remove people from the paths for user account pages.

I'm thinking change and then redirect sounds reasonable.

Issue #3334: [UX] Views: Pager "Number of pages", "Number of pager links visible", and "Pager ID" fields should be type 'number' instead of type 'textfield'

I guess the "Pager ID" field needs to be a number too ...according to its description.

[UX] Blocks: Style settings: Improve the UI for selecting between the 2 available options

> Would a radio set allow to hide the fields that are not used ... Yes, that can be done using `#states` 👍🏼 > ...including the not selected radio? That...