Greg Netsas

Results 1139 comments of Greg Netsas

@stpaultim I'm happy to merge this as is and follow-up on the a11y and border line issues 👍🏼 @jenlampton since you were the one that set the label of this...

@stpaultim my concerns about the same border added consistently around the draggable/droppable items in both UIs (rows in the flexible template UI, blocks in the layout UI) has been addressed...

So I made an initial attempt to port the most recent patch from https://www.drupal.org/project/drupal/issues/2539478#comment-11062307 (April 2016): https://github.com/backdrop/backdrop/pull/2743 I now don't get any visible errors, and no errors in the log...

...there's 100s of failed tests in the PR, so going through them may shed some light. Don't have the time for it now though 😓

...so `file_get_mimetype()` returns `application/octet-stream` instead of `image/svg+xml`, and this is apparently a Chrome bug: https://stackoverflow.com/questions/7771149/chrome-is-not-loading-svg-file-as-image-svgxml Digging deeper...

We'll need to re-evaluate this after the changes introduced in 1.25.0 in #4937, with the introduction for support of WebP and `image_get_supported_extensions()`.

I don't see any visibility conditions for menus or menu items. Are you referring to menu blocks perhaps? ...or is it something I'm missing?

> So do I. I know 🙂 ...I have some vacation time towards the end of July and end of August, and this is on my (long) list of to-dos...

This one is puzzling indeed 🤔 - First, I agree that we should be exposing that information somehow 👍🏼 - From a UX point of view, it makes sense to...